Shehab wchar fix #11
Merged
Shehab wchar fix #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-Shehab
force-pushed
the
shehab_wchar_fix
branch
from
5a594ff to
277abec
Compare
| @@ -540,6 +540,7 @@ foreach target : targets | |||
| 'test-ungetc-ftell', | |||
| 'test-fgetc', | |||
| 'test-fgets-eof', | |||
| 'test-wchar', | |||
There was a problem hiding this comment.
It would be good to run this test on the native library to make sure picolibc and glibc (the usual native library) agree on these semantics.
There was a problem hiding this comment.
test('test-wchar',
executable('test-wchar',
'test-wchar.c',
c_args: native_c_args,
link_args: native_c_args,
dependencies: native_lib_m))
@keith-packard, I'm not 100% sure about my understanding of the meson.build file, do you mean i need to add the test like that at line 625 instead of what i did ?
There was a problem hiding this comment.
Yes, but you need to add the native testing in addition to the regular test -- that way when doing "native" testing, we'll test the picolibc implementation and then also test the host C library implementation to validate the test itself. So, add what you've got above somewhere around line 625, yes, but also add 'test-wchar', to the list of simple tests.
This file is just a wrapper for picolibc.h. Delete unnecessary references to newlib.h or picolibc.h and replace the remaining ones with sys/features.h as that defines all of the features the library supports, not just those defined by the build system. Signed-off-by: Keith Packard <[email protected]>
Make sure any .c file includes picolibc.h before testing build parameters. Signed-off-by: Keith Packard <[email protected]>
Make this match other asm source in the library, even though it doesn't strictly need to as it doesn't use any C preprocessor stuff. Signed-off-by: Keith Packard <[email protected]>
Remove C library-specific bits for glibc or picolibc as the code is just plain-old POSIX and doesn't need any magic. Signed-off-by: Keith Packard <[email protected]>
Make sure library feature test macros are defined before being used. Signed-off-by: Keith Packard <[email protected]>
This file includes the regular strftime implementation, which also defines _DEFAULT_SOURCE. Fix that by undefining before including. Signed-off-by: Keith Packard <[email protected]>
Tinystdio uses a bunch of feature macros before including any headers. Signed-off-by: Keith Packard <[email protected]>
Go through all of the machine-specific source code and make sure picolibc.h is included so that all of the feature test macros are set before being used. Signed-off-by: Keith Packard <[email protected]>
These come from glibc where various 64-bit explicit APIs are provided under the protection of _LARGEFILE64_SOURCE, which is defined by _GNU_SOURCE. Replace the __LARGE64_FILES stuff with these and then use _GNU_SOURCE where needed as that exposes these APIs. We could use _LARGEFILE64_SOURCE instead, but it seems better to just expose the GNU API instead. Signed-off-by: Keith Packard <[email protected]>
This sets up a sample interrupt vector to show how this works. Signed-off-by: Keith Packard <[email protected]>
This mirrors the existing __signbit and __signbitf functions and allows a complete implementation of the non-builtin signbit macro. Change the internal inline version name to signbitl_inline like the other similar functions. Signed-off-by: Keith Packard <[email protected]>
Make sure all functions are declared fully in header files before being defined or used. Signed-off-by: Keith Packard <[email protected]>
This was needed before all source files were fixed to ensure all feature test macros were defined before being used by including sys/features.h Signed-off-by: Keith Packard <[email protected]>
Exposes these when _POSIX_C_SOURCE >= 199309L: int getc_unlocked (FILE *); int getchar_unlocked (void); void flockfile (FILE *); int ftrylockfile (FILE *); void funlockfile (FILE *); int putc_unlocked (int, FILE *); int putchar_unlocked (int); The I/O functions don't do anything different as tinystdio doesn't have any locking at the top level APIs. Getting these to poke down inside the buffered layer would improve performance at a pretty significant cost in complexity. flockfile/funlockfile is implemented using the global libc lock. This should at least serialize threads which all use this API. ftrylockfile is the same as flockfile as there's no try-lock API to use. Signed-off-by: Keith Packard <[email protected]>
A-Shehab
force-pushed
the
shehab_wchar_fix
branch
from
277abec to
3a35d97
Compare
According to ISO/IEC 9899/1999 section 7.19.2: Streams before this change wide character input/output functions were applied to byte-oriented stream resulting in erroneous results handling wide characters input/output to/from files. Signed-off-by: Ahmed Shehab <[email protected]>
keith-packard
force-pushed
the
shehab_wchar_fix
branch
from
3a35d97 to
02375d3
Compare
Added testcase that checks input/output wide-chars to/from a file. issue found by running SuperTest by Solid Sands Signed-off-by: Ahmed Shehab <[email protected]>
keith-packard
force-pushed
the
shehab_wchar_fix
branch
from
02375d3 to
b26c565
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to ISO/IEC 9899/1999 section 7.19.2: Streams
wide character input/output functions when applied to a stream should change the file orientation to be wide-oriented
before this change wide character input/output functions were applied to
byte-oriented stream resulting in erroneous results handling wide characters
input/output to/from files.